-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update README for public repo #285
Conversation
|
||
## Instructions | ||
|
||
### Install prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added prereqs below - correct?
|
||
- [Go](https://go.dev/doc/install) | ||
- [Docker](https://www.docker.com/get-started/) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run dev/test and dev/start, I get this error:
# github.com/lucas-clemente/quic-go/internal/qtls../../go/pkg/mod/github.com/lucas-clemente/
[email protected]/internal/qtls/go119.go:6:13: cannot use "The version of quic-go you're using
can't be built on Go 1.19 yet. For more details, please see https://github.com/lucas-clemente/
quic-go/wiki/quic-go-and-Go-versions." (untyped string constant "The version of quic-go
you're using can't be built on Go 1.19 yet. F...) as int value in variable declaration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks familiar, will need to dig in to figure out what to do. I think we used go 1.18 so far (at least that's what go.mod says).
|
||
This repo is private because this node software is not meant for public use. All nodes that currently form the XMTP network are run by XMTP Labs. | ||
At this time, all nodes in the XMTP network are run by XMTP Labs, whose mission is to promote and support the development and global adoption of XMTP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we stop using XMTP Labs? Maybe we can avoid using the direct reference here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mkobetic - I think we need to disclose who is operating the nodes - WDYT? What did you have in mind? =) I will be sure to keep this reference up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought we wanted to stop propagating that name. Otherwise no objection to the sentence as is.
No description provided.