-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject old SDK versions at API #405
Comments
Client work knowing what version and storing it as a header |
The easiest way to accomplish this is to start properly versioning This needs to be inserted into headers for requests in We might want to pair that with a more official release process for libxmtp, probably a lightweight one for now while there is still lots of churn. Should also consider whether we version our crates as one workspace, or version them separately by-crate. Probably, a workspace-wide version would work well -- this would ensure the sqlite-wasm backend could be versioned separately |
|
What exactly needs to be done from the sdk side? |
I don't think anything has to change for the SDKs, this should only be for libxmtp. I re-opened because I think this issue is also for changes to the go backend |
libxmtp version in the header of requests. Force requests to be on a good version and reject all requests that aren't on that version.
The text was updated successfully, but these errors were encountered: