Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot doesn't really work on this repo #113

Open
johnabass opened this issue Mar 23, 2023 · 1 comment
Open

dependabot doesn't really work on this repo #113

johnabass opened this issue Mar 23, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@johnabass
Copy link
Contributor

We use ugorji's code generation on the various wrp message structs. While this speeds up encoding and decoding, it does mean that we can't just update ugorji without rerunning the code generation. See: https://ugorji.net/blog/go-codecgen, specifically "How do I know if I have to re-generate the code?".

Dependabot, being a general tool, doesn't know anything about this requirement. That means that whenever dependabot thinks ugorji needs an update, all our unit tests for dependabot's PR fail. Example: #112

We should either (1) disable dependabot for this repo, or (2) figure out how to make dependabot smarter.

@johnabass johnabass added the bug Something isn't working label Mar 23, 2023
@schmidtw
Copy link
Member

Good catch. I think I'm missing a step during building where everything is regenerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants