Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add a few settings to apache config and php.ini to help sanitize the setup #10

Open
kobuki opened this issue Jun 5, 2020 · 0 comments

Comments

@kobuki
Copy link

kobuki commented Jun 5, 2020

Thanks for the easy to use image and compose config.

After a successful deployment I've discovered a few points that you might want to address.

  • look at the setup check page after deployment and modify the Dockerfile so that there are no warnings at all
  • the base path should be configurable, now it forces /, but it sometimes makes it pretty hard to proxy properly (we're using a reverse proxy with https termination and a specific url path), if not impossible

All these changes can be done inside the container and then committed, but it would make it a lot easier if the base image wouldn't need to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant