Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrections for https://github.com/xlab-si/xopera-examples/issues/42 #49

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Corrections for https://github.com/xlab-si/xopera-examples/issues/42 #49

merged 2 commits into from
Nov 10, 2021

Conversation

philippemerle
Copy link
Contributor

Corrections for #42

@philippemerle philippemerle mentioned this pull request Nov 10, 2021
Open
@anzoman anzoman self-requested a review November 10, 2021 12:25
@anzoman anzoman added bug Something isn't working TOSCA This has to do something with TOSCA standard labels Nov 10, 2021
anzoman
anzoman approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@anzoman anzoman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philippemerle for these big fixes!

@anzoman anzoman linked an issue Nov 10, 2021 that may be closed by this pull request
assigning a value expression to the default of a property/parameter/attribute definition is not allowed by TOSCA #42
Open
@anzoman anzoman merged commit b6bc824 into xlab-si:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anzoman anzoman anzoman approved these changes

Assignees
No one assigned
Labels
bug Something isn't working TOSCA This has to do something with TOSCA standard
Projects
None yet
Milestone
No milestone
2 participants
@philippemerle @anzoman