-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path resolution does not work for paths in the form of "file://networkname/path/to/file.mp4" (Lua: No such file or directory) #115
Comments
Hi @brassica77 :) You're right! It seems to be a bug. Could you tell me what is the actual path of that file if you were to access it from the command line? (either cmd or PowerShell) |
Thanks for the fast reply! |
Hi, |
Hi @xaf ! |
The problem comes from the parsing of the filepath. I will have to modify the way it is currently parsed to take into account this case. This may take a bit of time however as I'm also working on another issue currently! Will try to come to it soon :) |
Tell me if you need my help, testing betas or similar :-) |
Hi @brassica77 :) If it does not:
In order to check if any of those work, look for a line like the following in the logs:
As you can see here, the problem was that the Also, last thing, lines Thanks! :) |
I see a little progress. |
Mapping the network drive is what I was going to suggest. Nice to know it works! I will have to manage the error properly in TraktForVLC though. Regarding the fact that it stays running, can you please share the logs? I think that there's nothing I can do for that however, as it seems to be troubles in connection between the Lua script and the Python service, but might be caused by a number of stuff that I can't really pinpoint directly... I'll still take a look at the logs! |
When failing to open a file to resolve the hash, the interface was exiting on error because of the assertion. It can happen for a number of reasons that the file cannot be opened and this should not prevent TraktForVLC from working properly. This commit aims at managing the error properly by showing an error message and aborting the hash resolution. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
When a network drive is not mapped to a drive letter on Windows, the path will appear as an UNC path starting with 'file://'. However, Lua will fail to open that file to resolve the hash. This thus fixes that problem by changing the protocol from 'file' to 'unc' in order to avoid trying to resolve the hash when reading a media from an UNC path. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
The |
When failing to open a file to resolve the hash, the interface was exiting on error because of the assertion. It can happen for a number of reasons that the file cannot be opened and this should not prevent TraktForVLC from working properly. This commit aims at managing the error properly by showing an error message and aborting the hash resolution. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
When a network drive is not mapped to a drive letter on Windows, the path will appear as an UNC path starting with 'file://'. However, Lua will fail to open that file to resolve the hash. This thus fixes that problem by changing the protocol from 'file' to 'unc' in order to avoid trying to resolve the hash when reading a media from an UNC path. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
When failing to open a file to resolve the hash, the interface was exiting on error because of the assertion. It can happen for a number of reasons that the file cannot be opened and this should not prevent TraktForVLC from working properly. This commit aims at managing the error properly by showing an error message and aborting the hash resolution. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
When a network drive is not mapped to a drive letter on Windows, the path will appear as an UNC path starting with 'file://'. However, Lua will fail to open that file to resolve the hash. This thus fixes that problem by changing the protocol from 'file' to 'unc' in order to avoid trying to resolve the hash when reading a media from an UNC path. Relates to #115 Signed-off-by: Raphaël Beamonte <[email protected]>
Not sure how to get the logs in this case : even if I close VLC, in my account on Trakt there is still a red progress bar with percentage running. Edit : I see there is a new build : I will install it tonight when I get back home and will get you posted. |
The new build will not fix the current problem you're facing though. |
I saw them in the message console in VLC (Ctrl+M), and I think some of them are in the logs in my previous posts in this thread. |
Yss, it should run vlc in the normal way, but show you the logs in the console at the same time / after you close vlc (depending on the way the os wants to behave...) |
I am trying to install the new version and fail.
EDIT : manually removed the exe in /lua, trakt files in /intf, the json files in appdata, also removed the service, rebooted, tried to install : it detects it's a new install, but still get the "Error while configuring VLC" message and fails. |
What do you mean by that ?
Shouldn't be. The
Would be interesting to have the debug messages relative to that! Without knowing what fails, I cannot check how to fix it! |
I had to reset VLC settings and no more "Error while configuring VLC" message. |
The |
I can see the service in the services list, it is listed as running and automtaic start up. I tried a software called Taiga that basically does the same thing as TraktForVLC, except for animes only and anime related websites, and scrobbling is working, both with VLC and MPC-HC. I also installed Kodi, added the Trakt plugin, and set either VLC and MPC-HC as external players, and scrobbling is working too. And in these two cases, Taiga and Kodi, everything work without needing to add a Z:\ drive for the network path. Any idea what I could test next? |
@xaf any update on this? |
I am not sure, as this is the first time I am using both VLC and TraktForVLC, but I think I have an issue or maybe I need a clarification.
I am on Windows 10 Pro 64 bits and I am using VLC 3.0.3 64 bits.
TraktForVLC was installed successfully : I can see it in the autorized apps on Trakt.tv.
I can also see that a Service named TraktForVLC is present and running in Windows Services.
But when I launch a video file, whether it is a movie or a TV show or an anime I see nothing on Trakt.tv.
I noticed that there is absolutly no reference to Trakt in the log obtained by going in Tools/Messages if I launch a file by doube-clicking on it, but if I start VLC first, empty, and check the log window with verbose there are lines like this :
lua debug: Timers ran: { ["@trakt.lua:2365"] = false, ["@trakt.lua:1573"] = false, ["@trakt.lua:2617"] = false, }
And if I drag and drop a video file then, I get this :
lua error: Error loading script C:\Program Files\VideoLAN\VLC\lua\intf\trakt.luac: trakt.lua:313: diskstation/usbshare1/Download/alt.binaries.multimedia.anime/DARLING in the FRANXX/[Erai-raws] Darling in the FranXX - 18 [1080p][Multiple Subtitle].mkv: No such file or directory
Yet the file exists and is running fine in VLC.
Any ideas?
log.txt
The text was updated successfully, but these errors were encountered: