-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile: Profile Details module - Inline Edit component #193
Comments
@nicksp, considering my comment on respecting the controls shown to edit fields based on their type, I'd like to choose the option that is as generic as possible for fields of simple string/text type. If this means having a textfield where clicking Enter is save and clicking out of the area equates to cancel, then that's fine also (if it preserves edits locally while in the window if you need to go back to the edit component after scrolling or clicking elsewhere on the page for example). What do you suggest in relation to this, I'm open to options? |
@mccrodp Given the current scope, we will have 3 types of |
A follow-up task for https://zube.io/x-team/xp-formerly-auto/c/1956
To facilitate the functionality development, we'll need a generic inline-edit component that will support
onSave
andonCancel
custom callbacks to do respectively saving data and reverting it to the previous version. We should keep in mind it might be used for different unrelated fields on the admin dashboard, so it should be a generic one. Also, it would be great to support saving by clickingEnter
and canceling edit mode by clickingEsc
.On one of the last projects I implemented a similar component and would like to share a recording of how it works:
It was implemented the way it replicates Trello's similar component, but for our purposes, we can simplify that. I can share the code if required 😄
@mccrodp Do we want to have similar
Save
/Cancel
button when in edit mode? Or what are your expectations ofin-edit
mode?The text was updated successfully, but these errors were encountered: