Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route prefix is ignored on registration #36

Open
sersorrel opened this issue Jan 18, 2024 · 1 comment
Open

Route prefix is ignored on registration #36

sersorrel opened this issue Jan 18, 2024 · 1 comment

Comments

@sersorrel
Copy link
Member

Here, the API routes appear to be added directly to /:

def include_router() -> None:
return self.router.include_router(api.router)

so ServiceAPI.upload_artifacts ends up at /upload (rather than /service/upload).

I would expect api.prefix to be used there somewhere.

API.url() is unused, but appears to also expect prefix to be used:

return app.url(path=str(Path(cls.prefix) / path))

@sersorrel
Copy link
Member Author

...however, test code expects the current URL:

url="/upload?" + env_path,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant