Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostmanState.php::isTimeToReviewPostman() should always return a boolean value #92

Open
IanDelMar opened this issue Dec 22, 2024 · 0 comments

Comments

@IanDelMar
Copy link

If the condition on line 63 fails, PostmanState.php::isTimeToReviewPostman() does not return a boolean value.

public function isTimeToReviewPostman() {
if (! empty ( $this->options [self::INSTALL_DATE] )) {
$successful = PostmanState::getInstance ()->getSuccessfulDeliveries () > 0;
$maxTime = $this->options [self::INSTALL_DATE] + self::TOO_LONG_SEC;
return $successful && time () <= $maxTime;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant