Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #40 Update CDN cname #42

Open
wants to merge 40 commits into
base: develop
Choose a base branch
from
Open

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Oct 29, 2024

Description

Fixes #40

Automatically updates the current CDN cname on update of the plugin and display an info notice to inform the user

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Update the plugin

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Additional Checks

  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

@remyperona remyperona self-assigned this Oct 29, 2024
@remyperona remyperona added the enhancement New feature or request label Oct 29, 2024
@remyperona remyperona marked this pull request as ready for review October 30, 2024 19:37
@remyperona remyperona requested a review from a team October 30, 2024 19:37
@remyperona remyperona linked an issue Oct 30, 2024 that may be closed by this pull request
@hanna-meda
Copy link

Thank you, @remyperona, for this PR.
At first glance at it, we see the notification showing also for fresh plugin installations. According to the specs, we should have the notification only on update from a lower version than 1.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RocketCDN CNAME change
3 participants