Replies: 2 comments
-
This might actually be a very good idea. Good thinking. Would you be up for creating a PR? |
Beta Was this translation helpful? Give feedback.
0 replies
-
We've just release v3, and moved using macros for this. Thanks for the suggestion! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
One of the caveats of having the 'fake' method called on the FormRequest is the need for having the package installed in production. I was baffled, as FormRequest extends Request and Request is Macroable. FormRequests are Macroable.
Is it an idea to change this into macros? That way, when the package is installed (which usually is in dev) FormRequest automatically will have the fake method.
This will have no breaking change whatsoever. Users who use the HasFactory trait can keep using it or refactor it away at their choosing.
Beta Was this translation helpful? Give feedback.
All reactions