Make it compatible with symfony 5

[GalloisLuca]

Description
The plugin is not compatible with symfony 5

Example
!! The service "workouse_availability_notifier_plugin.controller.availability_
!! notifier" has a dependency on a non-existent service "templating". Did you
!! mean one of these: "sylius.templating.helper.convert_money", "sylius.templa
!! ting.helper.adjustment", "sylius.templating.helper.format_money", "sylius.t
!! emplating.helper.currency", "sylius.templating.helper.locale", "sylius.temp
!! lating.helper.inventory", "sylius.templating.helper.product_variants_prices
!! ", "sylius.templating.helper.price", "sylius.templating.helper.variant_reso
!! lver", "sylius.templating.helper.checkout_steps", "sylius.templating.helper
!! .grid", "sylius.templating.helper.bulk_action_grid", "sonata.block.templati
!! ng.helper", "liip_imagine.templating.filter_extension"?

[chadyred]

Any news about it ?

[delirehberi]

there is not active an development on that. we are open for prs.

[reyostallenberg]

Are you still open for PRs on that? I could and would like to help!

[delirehberi]

yes, we would like to review and merge.

[reyostallenberg]

Okay, it'll take some time to work on, but I think that is fine. I think you should first make a release (tag) on the current state, in order to give people a way to go back, as I think upgrading to current symfony and sylius will make some BC breaks.

…

On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ ***@***.***> wrote: yes, we would like to review and merge. — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ> . You are receiving this because you commented.Message ID: ***@***.***>

[delirehberi]

sure, i will do that tomorrow. On 4 May 2022 Wed at 01:31 Reyo Stallenberg ***@***.***> wrote:

…

Okay, it'll take some time to work on, but I think that is fine. I think you should first make a release (tag) on the current state, in order to give people a way to go back, as I think upgrading to current symfony and sylius will make some BC breaks. On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ ***@***.***> wrote: > yes, we would like to review and merge. > > — > Reply to this email directly, view it on GitHub > < #2 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ > > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEI7A73T42HXP3K6CM32TVIGSKXANCNFSM5A3WC6NQ> . You are receiving this because you commented.Message ID: ***@***.***>

[delirehberi]

@reyostallenberg tag v1.0.0 created.

[chadyred]

Well done ^^

[reyostallenberg]

@delirehberi do you agree we should only fix for supported versions.

That will mean:

• PHP 7.4/8.0/8.1
• Symfony 4.4/5.4/6.0
• Sylius 1.10/1.11 (as those fit the requirements above)

[delirehberi]

yes

…

On 10 May 2022 Tue at 10:17 Reyo Stallenberg ***@***.***> wrote: @delirehberi <https://github.com/delirehberi> do you agree we should only fix for supported versions. That will mean: - PHP 7.4/8.0/8.1 - Symfony 4.4/5.4/6.0 - Sylius 1.10/1.11 (as those fit the requirements above) — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEI7HC7MZR3XUEVZVSWODVJIESFANCNFSM5A3WC6NQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[reyostallenberg]

Is it possible to get the scrutinizer config in the repo, so I can fix it for current situation?
It'll mean the config done in the interface of scrutinizer should be deleted and should be added to the root of the repo in a yaml file

[delirehberi]

I sent a commit to master, is that ok?

[reyostallenberg]

That's okay

[costa-jeremy]

Hello,

It's possible to accept the PR pls ?

Thank you in advance

[delirehberi]

@costa-jeremy it will be merged after pr is completed. still seems work in progress.

[reyostallenberg]

I'll take a look in this shortly. I'm sorry for the delay