-
Notifications
You must be signed in to change notification settings - Fork 5
Make it compatible with symfony 5 #2
Comments
Any news about it ? |
there is not active an development on that. we are open for prs. |
Are you still open for PRs on that? I could and would like to help! |
yes, we would like to review and merge. |
Okay, it'll take some time to work on, but I think that is fine.
I think you should first make a release (tag) on the current state, in
order to give people a way to go back, as I think upgrading to current
symfony and sylius will make some BC breaks.
…On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ ***@***.***> wrote:
yes, we would like to review and merge.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
sure, i will do that tomorrow.
On 4 May 2022 Wed at 01:31 Reyo Stallenberg ***@***.***>
wrote:
… Okay, it'll take some time to work on, but I think that is fine.
I think you should first make a release (tag) on the current state, in
order to give people a way to go back, as I think upgrading to current
symfony and sylius will make some BC breaks.
On Wed, May 4, 2022 at 12:20 AM Emre YILMAZ ***@***.***>
wrote:
> yes, we would like to review and merge.
>
> —
> Reply to this email directly, view it on GitHub
> <
#2 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AA3JZUQSBISQVBSJYJXFS6TVIGRB7ANCNFSM5A3WC6NQ
>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEI7A73T42HXP3K6CM32TVIGSKXANCNFSM5A3WC6NQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@reyostallenberg tag v1.0.0 created. |
Well done ^^ |
@delirehberi do you agree we should only fix for supported versions. That will mean:
|
yes
…On 10 May 2022 Tue at 10:17 Reyo Stallenberg ***@***.***> wrote:
@delirehberi <https://github.com/delirehberi> do you agree we should only
fix for supported versions.
That will mean:
- PHP 7.4/8.0/8.1
- Symfony 4.4/5.4/6.0
- Sylius 1.10/1.11 (as those fit the requirements above)
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGEI7HC7MZR3XUEVZVSWODVJIESFANCNFSM5A3WC6NQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Is it possible to get the scrutinizer config in the repo, so I can fix it for current situation? |
scrutinizer config added to repo #2
I sent a commit to master, is that ok? |
That's okay |
Hello, It's possible to accept the PR pls ? Thank you in advance |
@costa-jeremy it will be merged after pr is completed. still seems work in progress. |
I'll take a look in this shortly. I'm sorry for the delay |
Description
The plugin is not compatible with symfony 5
Example
!! The service "workouse_availability_notifier_plugin.controller.availability_
!! notifier" has a dependency on a non-existent service "templating". Did you
!! mean one of these: "sylius.templating.helper.convert_money", "sylius.templa
!! ting.helper.adjustment", "sylius.templating.helper.format_money", "sylius.t
!! emplating.helper.currency", "sylius.templating.helper.locale", "sylius.temp
!! lating.helper.inventory", "sylius.templating.helper.product_variants_prices
!! ", "sylius.templating.helper.price", "sylius.templating.helper.variant_reso
!! lver", "sylius.templating.helper.checkout_steps", "sylius.templating.helper
!! .grid", "sylius.templating.helper.bulk_action_grid", "sonata.block.templati
!! ng.helper", "liip_imagine.templating.filter_extension"?
The text was updated successfully, but these errors were encountered: