-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform users when a permission is required for a demo #915
Comments
@bragefuglseth would you be interested in proposing a copy / design for 3? |
Hey, and sorry for the late response! I can have a shot at it if you can provide some textual content / an instruction set to be conveyed in the dialog. I'm not too knowledgeable on that stuff 😃 |
@bragefuglseth the dialog would show when a user press "Run" on a demo that require static Flatpak permissions (not portal permissions) that aren't enabled for Workbench. We can say something like: "Permission(s) needed" To run this project, additional permissions are needed for Workbench.
Here are screenshots of our current similar dialogs |
Sorry for the late response again! This is on my todo list. |
Any thoughts on this? I think it's nice to give a brief overview of what people are actually doing when running the command. The explanation can also serve as a useful introduction to the sandbox permission system for aspiring app developers. The descriptions may not be 100% accurate; you can change those as you see fit. I imagine that the external link symbol would open the sandbox permissions documentation. |
I love it :)
|
Currently, Workbench is considered as "probably safe" by Flathub and GNOME Software.
The reason it is not considered "Safe" is because we require network and audio permission (via
--socket=pulseaudio
and--share=network
. Those are not strictly required to use Workbench and are only needed for a handful of demos. In addition, we would also like to add a permission for gamepads workbenchdev/demos#88Eventually there will be portals for all of these things but until then we need static permissions.
Let's
flatpak-finish-args: ["--socket=fallback-x11"]
inmain.json
flatpak overrides
Since overrides are permanent - it should be a one time thing only anyway.
The text was updated successfully, but these errors were encountered: