Added new new methods to WordPressAuthenticatorDelegate to store site… #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… address, if the host app wishes to do so
… required by the host app
|
I will close this PR since the Woo issue can be fixed without making changes to the login library 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #641
Ref: woocommerce/woocommerce-ios/issues/3571
Changes
WordPressAuthenticatorDelegate:shouldStoreLoginSiteAddress()– This can be used by the host apps if we want to store the site address inUserDefaults, after the site address verification is successful.storeLoginSiteAddress()– This method captures the site address and can be used by the Woo app to store this address inUserDefaults.How to test
Disclaimer
This is my first time working on iOS and the WordPress Authenticator in a while so please feel free to leave any suggestions or improvements to the current code :)