-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] fix: delete 쿼리가 한 번만 나가도록 jpql을 사용한다. #833
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayonsoso
requested changes
Oct 11, 2024
@@ -7,7 +7,7 @@ | |||
public class NegativeHighlightIndexException extends BadRequestException { | |||
|
|||
public NegativeHighlightIndexException(long startIndex, long endIndex) { | |||
super("하이라이트 위치는 1 이상의 수이어야 해요."); | |||
super("하이라이트 위치는 0 이상의 수이어야 해요."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
귣귣
Comment on lines
+11
to
+16
@Modifying | ||
@Query(""" | ||
DELETE FROM Highlight h | ||
WHERE h.answerId IN :answersByReviewQuestion | ||
""") | ||
void deleteAllByIds(List<Long> answersByReviewQuestion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이 해브 어 퀘스티온~!!
전과 후에 delete 쿼리가 어떻게 바뀌는지 좀 더 설명해주실 수 있나요?🥹
#850 에서 함께 진행합니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말