Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] fix: delete 쿼리가 한 번만 나가도록 jpql을 사용한다. #833

Closed
wants to merge 2 commits into from

Conversation

skylar1220
Copy link
Contributor


🚀 어떤 기능을 구현했나요 ?

  • delete 쿼리가 한 번만 나가도록 jpql을 사용한다.

🔥 어떻게 해결했나요 ?

  • delete 쿼리가 한 번만 나가도록 jpql을 사용한다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

Copy link

Test Results

146 tests  ±0   146 ✅ ±0   4s ⏱️ -1s
 55 suites ±0     0 💤 ±0 
 55 files   ±0     0 ❌ ±0 

Results for commit b69bf32. ± Comparison against base commit b6d03d1.

@@ -7,7 +7,7 @@
public class NegativeHighlightIndexException extends BadRequestException {

public NegativeHighlightIndexException(long startIndex, long endIndex) {
super("하이라이트 위치는 1 이상의 수이어야 해요.");
super("하이라이트 위치는 0 이상의 수이어야 해요.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귣귣

Comment on lines +11 to +16
@Modifying
@Query("""
DELETE FROM Highlight h
WHERE h.answerId IN :answersByReviewQuestion
""")
void deleteAllByIds(List<Long> answersByReviewQuestion);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이 해브 어 퀘스티온~!!

전과 후에 delete 쿼리가 어떻게 바뀌는지 좀 더 설명해주실 수 있나요?🥹

@skylar1220
Copy link
Contributor Author

#850 에서 함께 진행합니다

@skylar1220 skylar1220 closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE] 에러 메시지의 오타를 수정하고 delete 쿼리를 한번만 나가도록 한다.
2 participants