[AN/USER] 축제 목록 캐싱 적용 (#591) #592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeongHoonC
requested changes
Oct 24, 2023
|
|
||
| interface FestivalRepository { | ||
| val festivals: Flow<List<Festival>> | ||
|
|
||
| suspend fun loadFestivals(): Result<List<Festival>> |
There was a problem hiding this comment.
실패 처리만 하고있어서 Result 만 반환해도 될 것 같네요
Comment on lines
+34
to
+43
| _uiState.value = FestivalListUiState.Success( | ||
| festivals = it.map { festival -> | ||
| FestivalItemUiState( | ||
| id = festival.id, | ||
| name = festival.name, | ||
| startDate = festival.startDate, | ||
| endDate = festival.endDate, | ||
| thumbnail = festival.thumbnail, | ||
| onFestivalDetail = ::showTicketReserve, | ||
| ) |
There was a problem hiding this comment.
개인적으로 private 함수로 분리했으면 좋겠습니당
EmilyCh0
reviewed
Oct 26, 2023
Comment on lines
+23
to
+34
| override val festivals: Flow<List<Festival>> | ||
| get() = festivalDao.getFestivals().transform { emit(it.toDomain()) } | ||
|
|
||
| override suspend fun loadFestivals(): Result<List<Festival>> = | ||
| runCatchingResponse { festivalRetrofitService.getFestivals() } | ||
| .onSuccessOrCatch { it.toDomain() } | ||
| .onSuccessOrCatch { festivals -> | ||
| festivals.toDomain().also { | ||
| CoroutineScope(Dispatchers.IO).launch { | ||
| festivalDao.replaceFestivals(it.toEntity()) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
서버에 새 데이터를 요청해서 불러오는 동안에 캐싱해둔 데이터를 보여줄 수 있고 좋네요 👍
(몰라서 하는 질문) 매번 내장 DB 테이블 전체를 Delete하고 Insert 하는 건 성능상 문제가 없나요??
Comment on lines
+52
to
+58
| festivalRepository.loadFestivals().onFailure { | ||
| _uiState.value = FestivalListUiState.Error | ||
| analyticsHelper.logNetworkFailure( | ||
| KEY_LOAD_FESTIVALS_LOG, | ||
| it.message.toString(), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Room 써서 캐싱까지 할거면 Error 상태일 때도 캐싱된 데이터를 보여주면 좋을 것 같은데 이 부분 상태나 이벤트 처리 어떻게 할지 얘기 해봐야할 것 같아요!
|
불필요 브랜치를 삭제하다가 삭제해버렸네요. 죄송합니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
val festivals을 추가하여 값을 Flow형태로 받아올 수 있게도 변경했습니다. 해당 구조에 대해서 피드백을 원합니다.