[BE] refactor: auth 패키지 내 클래스 정리 (#1005) #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results244 files 244 suites 27s ⏱️ Results for commit 8dc1dce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
auth패키지 내 제자리를 찾아가지 못하고 있는 클래스들을 정리했습니다.다만 DSM을 확인하니 양방향 의존이 있는 곳이 있길래 제거해보려 했으나...
common패키지에서GlobalExceptionHandler클래스가auth패키지의AuthenticateContext과Role을 의존하고 있더군요. 😂양방향 의존을 제거하려면
AuthenticateContext를 인터페이스로 만든 뒤,AuthenticateContextImpl을 만들고,Role과 관련된 어노테이션들을 모두common패키지에 이동시켜야 합니다.하지만 양방향 의존을 없애려고 인증에 관련된 여러 클래스들을 아무 상관이 없는
common에 두는 것이 오히려 역효과만 발생할 것 같습니다.(직관성에 어긋남)
따라서 우선 양방향 의존이 발생하게 두되, 거슬린다면 아예
common패키지에 있는GlobalExceptionHandler클래스를 다른 패키지로 이동시켜서 해결을 해봐야 할 것 같네요.(api 모듈)