Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New audit: excessive secret provisioning #401

Open
woodruffw opened this issue Jan 6, 2025 · 0 comments
Open

New audit: excessive secret provisioning #401

woodruffw opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
new-audit New audits

Comments

@woodruffw
Copy link
Owner

By default, the GitHub Actions runner will only include/inject explicitly referenced secrets. For example, if a repo has secrets.{foo,bar,baz} but workflow.yml only mentions secrets.{foo,bar}, then secrets.baz will not be included at runtime.

However, if the workflow references the entire secrets context, the runner can't filter the selected secrets and will instead include the entire context. For example:

# good: no other secrets added to runner
secrets.foo

# bad: adds all secrets to runner despite only accessing foo
fromJSON(secrets).foo

We should flag on any "bare" use of secrets.

Like #400, this is going to require some internal refactoring/rethinking to enable us to scan all expressions in the input, regardless of the context they appear in.

@woodruffw woodruffw added the new-audit New audits label Jan 6, 2025
@woodruffw woodruffw self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-audit New audits
Projects
None yet
Development

No branches or pull requests

1 participant