Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dangerous-triggers: change persona when permissions are constrained? #398

Open
woodruffw opened this issue Jan 6, 2025 · 1 comment
Open

dangerous-triggers: change persona when permissions are constrained? #398

woodruffw opened this issue Jan 6, 2025 · 1 comment
Assignees
@woodruffw

Comments

@woodruffw
Copy link
Owner

Filing this so I don't forget about it. Needs more thought.

The risk of a pull_request_target or similar is significantly diminished when permissions: {} or similarly constrained. We should consider emitting a "pedantic" or "auditor"-only finding in these cases.

h/t @MikeMcQuaid for raising 🙂
@woodruffw woodruffw self-assigned this Jan 6, 2025
@MikeMcQuaid
Copy link

Perhaps somewhat related: pull_request_target that never actually uses e.g. actions/checkout to checkout the relevant code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeMcQuaid @woodruffw