Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New audit: artifact poisoning #195

Open
woodruffw opened this issue Nov 24, 2024 · 0 comments
Open

New audit: artifact poisoning #195

woodruffw opened this issue Nov 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request new-audit New audits

Comments

@woodruffw
Copy link
Owner

Repositories and their forks share the same artifact ID namespace, which means that an attacker-controlled fork can poison the artifacts for an upstream workflow that uses the workflow artifact APIs (or an action like dawidd6/action-download-artifact) to download cross-workflow artifacts.

Versions of dawidd6/action-download-artifact before v6 had allow_forks: true by default. These should now be caught by our vulnerable-actions audit thanks to GHSA-5xr6-xhww-33m4.

However, it'd still be good to catch these more generally. That includes:

  • dawidd6/action-download-artifact v6+ where the user explicitly does allow_forks: true
  • Other similar workflows that still do the same thing by default
  • People using the REST APIs directly via actions/github-script or similar (github.actions.listWorkflowRunArtifacts(...)) without appropriate filtering

That last one is a bit harder to do, but we can certainly handle the first two.

Assigning this to myself.

@woodruffw woodruffw added enhancement New feature or request new-audit New audits labels Nov 24, 2024
@woodruffw woodruffw self-assigned this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-audit New audits
Projects
None yet
Development

No branches or pull requests

1 participant