Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Reorganise storybook to ensure all exported components are available in the "External components" section. #11908

Closed
opr opened this issue Nov 22, 2023 · 3 comments · Fixed by #11910
Assignees
Labels
focus: components Work that introduces new or updates existing components. focus: documentation This issue is a request for better documentation. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: storybook Issues related to storybook.

Comments

@opr
Copy link
Contributor

opr commented Nov 22, 2023

Following on from our effort to Move components into the components package and to add Storybook entries for them, we now need to do some housekeeping on Storybook.

All components we export via @woocommerce/blocks-components should be in their own folder on Storybook.

To solve this issue, find the stories for each component in packages/components/**/stories/*.tsx and ensure the story title is:

External Components/{Component} like so:

@opr opr added type: enhancement The issue is a request for an enhancement. focus: documentation This issue is a request for better documentation. focus: components Work that introduces new or updates existing components. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: storybook Issues related to storybook. labels Nov 22, 2023
@arsanyjoseph
Copy link
Contributor

I would like to contribute to this
Would you please assign me ?

@opr
Copy link
Contributor Author

opr commented Nov 22, 2023

@arsanyjoseph sure! I've assigned you to this task. Please let me know if you need any help.

To get storybook running you need to run npm run storybook on the command line then go to localhost:6006

By the way if you're not already in the WooCommerce Community Slack then feel free to join and ping me there too.

Thanks for offering to help!

@arsanyjoseph
Copy link
Contributor

@opr I created a PR
kindly review it and let me know if any further changes required.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: components Work that introduces new or updates existing components. focus: documentation This issue is a request for better documentation. type: enhancement The issue is a request for an enhancement. type: good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: storybook Issues related to storybook.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants