From c8eb657c4a809c7fc869dd80e8aaafc43da51266 Mon Sep 17 00:00:00 2001 From: Niels Lange Date: Tue, 14 Nov 2023 14:22:26 +0700 Subject: [PATCH 001/165] Update changelog and testing notes for release 11.4.8 --- .../testing/releases/1148.md | 29 +++++++++++++++++++ .../testing/releases/README.md | 1 + readme.txt | 6 ++++ 3 files changed, 36 insertions(+) create mode 100644 docs/internal-developers/testing/releases/1148.md diff --git a/docs/internal-developers/testing/releases/1148.md b/docs/internal-developers/testing/releases/1148.md new file mode 100644 index 00000000000..7385318f874 --- /dev/null +++ b/docs/internal-developers/testing/releases/1148.md @@ -0,0 +1,29 @@ +# Testing notes and ZIP for release 11.4.8 + +Zip file for testing: [woocommerce-gutenberg-products-block.zip](https://github.com/woocommerce/woocommerce-blocks/files/13323235/woocommerce-gutenberg-products-block.zip) + +## WooCommerce Core + +### Bug Fixes + +#### Ensure that incompatible notices are displayed in Safari ([11736](https://github.com/woocommerce/woocommerce-blocks/pull/11736)) + +1. Install and activate [helper-plugin-1.zip](https://github.com/woocommerce/woocommerce-blocks/files/12701036/helper-plugin-1.zip) +2. Create a test page and add the Cart block. +3. Create a test page and add the Checkout block. +4. Open both test pages using Safari. +5. Click on the Cart block resp. the Checkout block and verify that the incompatible extension notice is visible. +6. Repeat the previous step using Chrome, Firefox and Opera. + + + + + + +
Before: +

+Screenshot 2023-11-10 at 21 43 01 +
After: +

+Screenshot 2023-11-10 at 21 42 18 +
diff --git a/docs/internal-developers/testing/releases/README.md b/docs/internal-developers/testing/releases/README.md index cbcf182354d..4c0a2f080f7 100644 --- a/docs/internal-developers/testing/releases/README.md +++ b/docs/internal-developers/testing/releases/README.md @@ -190,6 +190,7 @@ Every release includes specific testing instructions for new features and bug fi - [11.4.5](./1145.md) - [11.4.6](./1146.md) - [11.4.7](./1147.md) + - [11.4.8](./1148.md) - [11.5.0](./1150.md) - [11.5.1](./1151.md) - [11.5.4](./1154.md) diff --git a/readme.txt b/readme.txt index 540e6d393d1..0271885b992 100644 --- a/readme.txt +++ b/readme.txt @@ -150,6 +150,12 @@ Release and roadmap notes available on the [WooCommerce Developers Blog](https:/ - Remove bullet points and unnecessary padding from `SearchListControl`. ([11444](https://github.com/woocommerce/woocommerce-blocks/pull/11444)) += 11.4.8 - 2023-11-10 = + +#### Bug Fixes + +- Ensure that incompatible notices are displayed in Safari. [11736](https://github.com/woocommerce/woocommerce-blocks/pull/11736) + = 11.4.7 - 2023-11-09 = #### Bug Fixes From 06835879ec398a95af88c8493d185203598fc860 Mon Sep 17 00:00:00 2001 From: Alex Florisca Date: Tue, 14 Nov 2023 09:58:57 +0000 Subject: [PATCH 002/165] Add storybook entry for Label component (#11682) --- packages/components/label/index.tsx | 6 +-- .../label/stories/index.stories.tsx | 51 +++++++++++++++++++ 2 files changed, 54 insertions(+), 3 deletions(-) create mode 100644 packages/components/label/stories/index.stories.tsx diff --git a/packages/components/label/index.tsx b/packages/components/label/index.tsx index 0df3aa02d35..ea4f2b3b8d2 100644 --- a/packages/components/label/index.tsx +++ b/packages/components/label/index.tsx @@ -5,9 +5,9 @@ import { Fragment } from '@wordpress/element'; import classNames from 'classnames'; import type { ReactElement, HTMLProps } from 'react'; -interface LabelProps extends HTMLProps< HTMLElement > { - label?: string | undefined; - screenReaderLabel?: string | undefined; +export interface LabelProps extends HTMLProps< HTMLElement > { + label?: string; + screenReaderLabel?: string; wrapperElement?: string; wrapperProps?: HTMLProps< HTMLElement >; } diff --git a/packages/components/label/stories/index.stories.tsx b/packages/components/label/stories/index.stories.tsx new file mode 100644 index 00000000000..524521a26ae --- /dev/null +++ b/packages/components/label/stories/index.stories.tsx @@ -0,0 +1,51 @@ +/** + * External dependencies + */ +import type { StoryFn, Meta } from '@storybook/react'; + +/** + * Internal dependencies + */ +import Label, { LabelProps } from '..'; + +export default { + title: 'External Components/Label', + component: Label, + argTypes: { + label: { + control: { + type: 'text', + }, + description: 'The label to be displayed.', + }, + screenReaderLabel: { + control: { + type: 'text', + }, + description: 'The label to be read by screen readers.', + }, + wrapperElement: { + control: { + type: 'text', + }, + description: + 'HTML element to wrap around the label component (e.g. "span").', + }, + wrapperProps: { + control: { + type: 'object', + }, + description: 'The props to be passed to the wrapper element.', + }, + }, +} as Meta< LabelProps >; + +const Template: StoryFn = ( args ) =>