Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Passkey fetching through the Credential Manager API #10557

Closed
2 of 3 tasks
Assignees
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.

Comments

@ThomazFB
Copy link
Contributor

ThomazFB commented Jan 16, 2024

Summary

We discovered that a new version 1.2.0 of the Credential Manager was released after the Passkey project development, containing lots of async functions counterparts within the API with it. E.g.:

The getCredential function, which is a suspend function used to retrieve a Passkey data from a Challenge, is now followed by a getCredentialAsync function, which is not suspend and relies on a callback instead.

This seems to be a very intentional move from Google to support Java usage with the Credential Manager, and it might be a very good alternative to avoid a drastic change inside the WordPress Login library. We can verify in the docs statements like This API uses callbacks instead of Kotlin coroutines.

Our goal here is to ensure we're adopting the Credential Manager through this callback structure since the WordPress Login library still doesn't have proper support for the Kotlin Coroutines usage.

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: login Related to any part of the log in or sign in flow, or authentication. type: task An internally driven task.
Projects
None yet
1 participant