Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in kyber.h header prevents using wc_MlKemKey_Decapsulate alias #8041

Closed
tobiasbrunner opened this issue Oct 4, 2024 · 3 comments · Fixed by #8405
Closed

Typo in kyber.h header prevents using wc_MlKemKey_Decapsulate alias #8041

tobiasbrunner opened this issue Oct 4, 2024 · 3 comments · Fixed by #8405
Assignees
Labels

Comments

@tobiasbrunner
Copy link

wc_MlKemKey_Decapsulate is incorrectly mapped to wc_KyberKey_Encapsulate instead of wc_KyberKey_Decapsulate:

#define wc_MlKemKey_Decapsulate wc_KyberKey_Encapsulate

@tobiasbrunner
Copy link
Author

Just another small fixup:

[AS_HELP_STRING([--enable-kyber],[Enable KYBER (requires --enable-experimental) (default: disabled)])],

Doesn't seem the experimental switch is required anymore.

@embhorn embhorn added the bug label Oct 4, 2024
@anhu
Copy link
Member

anhu commented Jan 31, 2025

Hi @tobiasbrunner ,

Thank you so much for letting us know about these issues. I will have fixes for them in a PR very soon. I sincerely apologize for the delay in my response time.

Warm regards, Anthony

@anhu
Copy link
Member

anhu commented Jan 31, 2025

Please see #8405 . I'm sure this will be merged fairly quickly. As such I will now close this issue. Thank you again for letting us know about this.

Warm regards, Anthony

@anhu anhu closed this as completed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants