Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a typo in esp32_sha.c #7606

Closed
Jreuningschererhubbell opened this issue May 31, 2024 · 1 comment · Fixed by #7607
Closed

Found a typo in esp32_sha.c #7606

Jreuningschererhubbell opened this issue May 31, 2024 · 1 comment · Fixed by #7607
Assignees

Comments

@Jreuningschererhubbell
Copy link

Jreuningschererhubbell commented May 31, 2024

The file wolfcrypt/src/port/Espressif/esp32_sha.c has a typo in line 1523.

SP_LOGI(TAG, "3) esp_sha_hw_unlock Lock depth @ %d = %d "

The correct function name is ESP_LOGI.

Compiling for ESP32 with the typo results in an 'implicit function declaration error':

REDACTED-PATH/wolfssl/wolfcrypt/src/port/Espressif/esp32_sha.c: In function 'esp_sha_hw_unlock':
REDACTED-PATH/wolfssl/wolfcrypt/src/port/Espressif/esp32_sha.c:1523:5: error: implicit declaration of function 'SP_LOGI'; did you mean 'ESP_LOGI'? [-Werror=implicit-function-declaration]
 1523 |     SP_LOGI(TAG, "3) esp_sha_hw_unlock Lock depth @ %d = %d "
      |     ^~~~~~~
      |     ESP_LOGI
cc1: some warnings being treated as errors

Compiling for ESP32 with the corrected function name succeeds.

I discovered this issue when I enabled WOLFSSL_ESP32_HW_LOCK_DEBUG while working with a ESP32-WROOM-32E.

Thanks!

Edit: I misspelled 'REDACTED'

gojimmypi added a commit to gojimmypi/wolfssl that referenced this issue May 31, 2024
@gojimmypi
Copy link
Contributor

Hi @Jreuningschererhubbell and thank you for reporting this! I've created #7607 to fix it.

We're always interested in what folks are doing with wolfSSL. Please let me know more about your project here or if you prefer privacy you can reach me at [email protected], or for general support: [email protected].

I have a particular interest in the Espressif code; I'd like to make sure it is robust and flexible. Any additional feedback is welcome.

dgarske added a commit that referenced this issue Jun 1, 2024
Fix for #7606: ESP_LOGI typo in esp32_sha.c
jefferyq2 pushed a commit to jefferyq2/wolfssl that referenced this issue Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants