0.5.0 edge case #328
james-d-elliott
started this conversation in
General
Replies: 2 comments
-
Thanks for bringing this up James. Do you have a code example for this behaviour? Maybe it's useful to add it as a test, so we don't accidently breakt things with a next release. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Linking #332 here for completeness. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
There's an edge case where performing a no auth SMTP connection on 0.5.0 has changed. Specifically to be able to do this (SMTP without auth) now you must explicitly set
mail.WithSMTPAuthCustom(nil)
ormail.WithSMTPAuth(mail.SMTPAuthCustom)
with no other auth option in order to perform this action, while prior if no auth option was ever used it was happy to perform no auth.While this is technically a breaking change I think it's overall a good move for the lib and makes the interaction more explicit. I suspect the original behavior was never intended.
Beta Was this translation helpful? Give feedback.
All reactions