Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npx rnn-link is outdated aswell as a documentation #7943

Open
1 task done
rendomnet opened this issue Dec 2, 2024 · 6 comments
Open
1 task done

npx rnn-link is outdated aswell as a documentation #7943

rendomnet opened this issue Dec 2, 2024 · 6 comments

Comments

@rendomnet
Copy link

rendomnet commented Dec 2, 2024

What happened?

A lot of errors when trying to add rnn to blank new react native project.

npx rnn-link
is not working with android and kotlin files.

Documentation is also outdated
https://wix.github.io/react-native-navigation/next/docs/installing

What was the expected behaviour?

No response

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

No response

In what environment did this happen?

React Native Navigation version: "^7.40.3"
React Native version: "0.76.3",
Has Fabric (React Native's new rendering system) enabled: (yes/no)
Node version: 18
Device model:
Android version: 35

@rendomnet rendomnet changed the title npx rnn-link is outdates aswell as documentation npx rnn-link is outdated aswell as a documentation Dec 3, 2024
@retyui
Copy link
Contributor

retyui commented Dec 3, 2024

see #7821 (comment)

@rendomnet
Copy link
Author

Can somebody confirm that react-native-navigation is working with react-native 0.76.3?

@retyui
Copy link
Contributor

retyui commented Dec 4, 2024

@rendomnet Yes it's working. after linking you need to apply patches for android

do this setup https://www.npmjs.com/package/patch-package#set-up
and put this file react-native-navigation+7.40.3.patch into a ./patches folder and run once npx patch-package

@rendomnet
Copy link
Author

@rendomnet Yes it's working. after linking you need to apply patches for android

do this setup https://www.npmjs.com/package/patch-package#set-up and put this file react-native-navigation+7.40.3.patch into a ./patches folder and run once npx patch-package

I tried it with blank new react-native project and it is not working for iOS and Android.
https://github.com/rendomnet/repro-bug-rnn

@rendomnet
Copy link
Author

@retyui
This is what 'yarn ios' returns after completing your steps.

error limit 19 -serialize-diagnostic-file /Users/user/Library/Developer/Xcode/DerivedData/AwesomeProject-eqnrzhjzjreegcfjxgmvkdzfeljt/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/ReactNativeNavigation.build/Objects-normal/arm64/UIViewController+SideMenuController.dia -Wdeprecated-objc-isa-usage -Werror\=deprecated-objc-isa-usage -Werror\=implicit-function-declaration -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Wno-implicit-atomic-properties -Werror\=deprecated-objc-isa-usage -Wno-objc-interface-ivars -Werror\=objc-root-class -Wno-arc-repeated-use-of-weak -Wimplicit-retain-self -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wdeprecated-implementations -Wno-implicit-fallthrough -Wprotocol -Wdeprecated-declarations -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wno-semicolon-before-method-body -Wunguarded-availability -Wno-comma -Wno-shorten-64-to-32 -Wno-reorder-init-list -Wno-implicit-int-float-conversion -Wno-c99-designator -Wno-final-dtor-non-final-class -Wno-extra-semi-stmt -Wno-misleading-indentation -Wno-quoted-include-in-framework-header -Wno-implicit-fallthrough -Wno-enum-enum-conversion -Wno-enum-float-conversion -Wno-elaborated-enum-base -Wno-reserved-identifier -Wno-gnu-folding-constant -index-store-path /Users/user/Library/Developer/Xcode/DerivedData/AwesomeProject-eqnrzhjzjreegcfjxgmvkdzfeljt/Index.noindex/DataStore -index-unit-output-path /Pods.build/Debug-iphonesimulator/ReactNativeNavigation.build/Objects-normal/arm64/UIViewController+SideMenuController.o -fmodule-map-file\=/Users/user/Library/Developer/Xcode/DerivedData/AwesomeProject-eqnrzhjzjreegcfjxgmvkdzfeljt/

@rendomnet
Copy link
Author

rendomnet commented Dec 6, 2024

@retyui
and 'yarn android' is built but crashes immediately upon launch.

So my question still stands, can someone confirm that latest rnn is working with latest react-native. using the guide above with newly created react-native blank project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants