Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No known class method for selector 'UIBarStyle:'. - i.e. React Native v0.76.x support #7920

Open
1 task done
fmorau opened this issue Oct 2, 2024 · 9 comments
Open
1 task done

Comments

@fmorau
Copy link

fmorau commented Oct 2, 2024

What happened?

If you upgrade to 0.76.x - app is not launching due to issue No known class method for selector 'UIBarStyle:'

What was the expected behaviour?

React Native Navigation does not prevent app to build and launch

Was it tested on latest react-native-navigation?

  • I have tested this issue on the latest react-native-navigation release and it still reproduces.

Help us reproduce this issue!

Just try to use RNN with RN v0.76.x
You can check the PR: https://github.com/facebook/react-native/pull/44597/files, which removed support of [RCTConvert UIBarStyle:...]

In what environment did this happen?

React Native Navigation version: 7.40.1
React Native version: 0.76.0-rc.2
Has Fabric (React Native's new rendering system) enabled: no
Node version: v18.19.0
Device model: Simulator
iOS version: 18

@OskarEichler
Copy link

Running into the same issue!

@oferRounds
Copy link

@fmorau did you find any solution?

@fmorau
Copy link
Author

fmorau commented Nov 8, 2024

@fmorau did you find any solution?

this part inside RNN library should be refactored

@dkjeune
Copy link

dkjeune commented Nov 21, 2024

same issue for me, any solution ?

@f0wu5u
Copy link

f0wu5u commented Dec 22, 2024

RCTConvert UIBarStyle has been removed from React Native core here facebook/react-native@a557a81

@f0wu5u
Copy link

f0wu5u commented Dec 22, 2024

Attached is a patch file that resolves the issue for me... Sorry I am not ObjectiveC guy so code might not be fancy
Screenshot 2024-12-23 at 00 31 29

react-native-navigation+7.40.3.patch

@elsurudo
Copy link

Thanks @f0wu5u! WDYT of making a PR to the project so that it can be merged into mainline?

@f0wu5u
Copy link

f0wu5u commented Dec 23, 2024

@elsurudo as I said I am not sure the code is best for ObjectiveC but if someone can reason around my version and come up with a better version for the PR I would be happy

@DriesVS
Copy link

DriesVS commented Dec 26, 2024

PR created #7950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants