Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sleep statements from test suite #5

Open
wilsonsilva opened this issue Jan 22, 2023 · 0 comments · May be fixed by #17
Open

remove sleep statements from test suite #5

wilsonsilva opened this issue Jan 22, 2023 · 0 comments · May be fixed by #17
Labels
help wanted Extra attention is needed

Comments

@wilsonsilva
Copy link
Owner

wilsonsilva commented Jan 22, 2023 •
edited
Loading

The test suite is fairly fast despite the sleep statements, but it feels dirty (because it is) and makes the test suite non-determinant. Help welcome.
@wilsonsilva wilsonsilva added the help wanted Extra attention is needed label Feb 22, 2023
raucao added a commit to raucao/nostr that referenced this issue Sep 25, 2024
@raucao
Refactor client spec to remove sleep statements
44e7454 
Instead of using random sleep values, add a `wait_for` helper method,
which efficiently waits until async operations have changed the expected
variables before running the assertions.

closes wilsonsilva#5
@raucao raucao linked a pull request Sep 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor client spec to remove sleep statements raucao/nostr
1 participant
@wilsonsilva