Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot import name 'default_rulesdir' from 'ansiblelint' #91

Open
ekbfh opened this issue Aug 24, 2020 · 2 comments · May be fixed by #92
Open

cannot import name 'default_rulesdir' from 'ansiblelint' #91

ekbfh opened this issue Aug 24, 2020 · 2 comments · May be fixed by #92

Comments

@ekbfh
Copy link

ekbfh commented Aug 24, 2020

Hi!

Recently https://github.com/ansible/ansible-lint was updated from 4.2.0 to 4.3.[0,1].
And now ansible-review don't worked with error:

ansible-review --version
Traceback (most recent call last):
  File "/usr/local/bin/ansible-review", line 5, in <module>
    from ansiblereview.__main__ import main
  File "/usr/local/lib/python3.8/site-packages/ansiblereview/__init__.py", line 1, in <module>
    from ansiblelint import default_rulesdir, RulesCollection
ImportError: cannot import name 'default_rulesdir' from 'ansiblelint' (/usr/local/lib/python3.8/site-packages/ansiblelint/__init__.py)

I think it may be caused by ansible/ansible-lint@734c6f8#diff-3a0d2814ee14f24f804a7c3bd1c7863a
@kevinkirkup
Copy link

Actually, I think it's this one:
ansible/ansible-lint@55043d6

@kevinkirkup
Copy link

kevinkirkup commented Aug 24, 2020 •
edited
Loading

Can you patch this? Ansible-review is completely broken at the moment.

kevinkirkup pushed a commit to pureport/ansible-review that referenced this issue Aug 24, 2020
Fix invalid import default_rulesdir
cfc6ae4 
Fixes willthames#91. Pin the ansible-lint version.
Current version 4.3.1 refactor *default_rulesdir* away.
kevinkirkup pushed a commit to pureport/ansible-review that referenced this issue Aug 24, 2020
Fix invalid import default_rulesdir
5f3d695 
Fixes willthames#91. Pin the ansible-lint version.
Current version 4.3.1 refactor *default_rulesdir* away.
kevinkirkup pushed a commit to pureport/ansible-review that referenced this issue Aug 24, 2020
Fix invalid import default_rulesdir
9050270 
Fixes willthames#91. Pin the ansible-lint version.
Current version 4.3.1 refactor *default_rulesdir* away.
@kevinkirkup kevinkirkup linked a pull request Aug 24, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cannot import name 'default_rulesdir' from 'ansiblelint' pureport/ansible-review
2 participants
@kevinkirkup @ekbfh