Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation Webhook #142

Open
jmesnil opened this issue Apr 7, 2020 · 0 comments
Open

Add validation Webhook #142

jmesnil opened this issue Apr 7, 2020 · 0 comments
Labels
Basic Install (I) Features for Phase I of the Operator capability levels

Comments

@jmesnil
Copy link
Member

jmesnil commented Apr 7, 2020

With #27, the WildFlyServerSpec CRD expects the presence of applicationSource XOR applicationImage field.

I've not been able to find a way to express this mutual exclusion of fields with the k8s OpenAPI validation schema.
We have to install a validation Webhook to verify these additional constraints. Once a webhook is in place, we can add more validation to prevent installation of a WildFlyServerSpec that is not correct:

  • either applicationSource XOR applicationImage field must be set
  • verify that the referenced image stream tags for WildFly S2I images are available
  • etc.
@jmesnil jmesnil added the Basic Install (I) Features for Phase I of the Operator capability levels label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Basic Install (I) Features for Phase I of the Operator capability levels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesnil