Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifier not checking for new reviews; seems to default to lessons #6

Open
filler-arc opened this issue Jan 2, 2022 · 1 comment
Open

Comments

@filler-arc
Copy link

If I complete all outstanding reviews, the notifier button will take me to lessons as expected.
However, it doesn't seem to update its badge when new reviews become available and just defaults to the lessons page when I click on it.

The only way I've found to reset this is to go into the actual Reviews module, which then updates the icon badge.

I'm running Firefox 95.0.2 for reference. Thanks for all the work on this extension!

@curiousjp
Copy link

I think the issue is that line 51,

if (when) browser.alarms.create(REFRESH_ALARM, { when });

is wrong. It passes in a timestamp in the form "2022-11-15T00:00:00.000Z". On Firefox, when is a double in milliseconds past the epoch. Something like this would work:

if (when) { wd = new Date( when ).getTime(); browser.alarms.create(REFRESH_ALARM, { when: wd }); }

@wiiaboo , have you retired this project? The requirement that addons now be signed makes this hard to fix myself, and I am not really up to scratch on how to contribute fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants