Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light mode appearance: icons, text colors #712

Open
Artoria2e5 opened this issue Sep 23, 2024 · 4 comments
Open

Light mode appearance: icons, text colors #712

Artoria2e5 opened this issue Sep 23, 2024 · 4 comments

Comments

@Artoria2e5
Copy link
Contributor

We got the much-needed light mode in #476, but I would think that most people agree that something looks off about it. So what's really wrong with it?

Compare:
image
temp

Icons

The icons on top look like thin skeletons in light mode. We need to provide inverted versions of the icons, so they look about as thick as they do in dark mode.

Text color

Text appears in a variety of colors in dark mode; more important text is given a brighter color, so they have higher contrast against the background. Light mode does not have this kind of color-importance correspondance:

  • The MAC address and the encryption parts, which should be less important than the wifi name, currently renders as the same black color as the wifi name.
  • The lat/lon display is too faint for its level of importance.
@rksh
Copy link
Contributor

rksh commented Sep 27, 2024

Pull requests are very welcome!

@rksh
Copy link
Contributor

rksh commented Nov 7, 2024

the menu icons work that way because the R.attr.colorControlNormal tint doesn't appear to get applied to them - could be because they from the android.R.drawable.ic_menu... family

@rksh
Copy link
Contributor

rksh commented Nov 7, 2024

ah, yes, they're image chains.

rksh pushed a commit to rksh/wigle-wifi-wardriving that referenced this issue Nov 9, 2024
rksh added a commit that referenced this issue Nov 9, 2024
* first cut at SVG-izing non-day/night themeing icons

* addressing #712 icon concerns

---------

Co-authored-by: Andy Carra <[email protected]>
@rksh
Copy link
Contributor

rksh commented Jan 16, 2025

#725 submitted to slim down the lines of the new icons somewhat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants