Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing disc tray should only happen when supported #615

Open
hadess opened this issue Apr 26, 2024 · 2 comments
Open

Closing disc tray should only happen when supported #615

hadess opened this issue Apr 26, 2024 · 2 comments

Comments

@hadess
Copy link

hadess commented Apr 26, 2024

Using whipper-0.10.0-11.fc39.x86_64

WARNING:whipper.program.utils:command 'eject -t /dev/sr0' returned with exit code '1' (b'eject: CD-ROM tray close command failed: No such file or directory')

My CD drive is a Hitachi-LG BU40N blu-ray drive that doesn't have a tray that can be programmatically closed.

image

Ideally, whipper could detect that the device doesn't support closing the tray, and would set drive_auto_close for the drive itself rather than globally.

Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@MerlijnWajer
Copy link
Collaborator

I suppose we might be able to use the CDC_OPEN_TRAY flag, presuming that is set correctly for the CDROM_GET_CAPABILITY ioctl. Maybe you could check if that's set correctly for your drive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants