Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wet-boew/theme-gcwu-fegc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.27
Choose a base ref
...
head repository: wet-boew/theme-gcwu-fegc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 3 commits
  • 12 files changed
  • 3 contributors

Commits on Dec 14, 2017

  1. Copy the full SHA
    675bf72 View commit details

Commits on Feb 14, 2018

  1. Theme: Reference SVG logos with img element instead of object.

    * Port of wet-boew/wet-boew#8282.
    * Related to wet-boew/wet-boew#8276.
    * Adds a CSS filter to change the signature/wordmark SVGs' colours to white in screen views:
      * Needed for Gecko, Blink and possibly Webkit due to their buggy handling of inline SVG media queries when the img element is used. When printing, they apply screen-only queries and ignore print-only queries.
      * Prevents the fallback PNG logos from being coloured white when printing in browsers that support CSS filters.
    * Modifies the signature/wordmark SVGs' inline media queries to only change their colours to white in Internet Explorer 10-11 screen views:
      * Since IE10-11 correctly handle the aforementioned media queries but lack support for CSS filters, this is the most viable setup to make the signature/wordmark render correctly in all of WET's supported browsers.
    * Modifies SCSS to increase the bottom margins on the signature/wordmark images to replicate the empty space that was previously appearing below their object element containers.
    * Prevents the signature/wordmark SVGs from disappearing in Blink and possibly Webkit's print views in certain page templates.
    EricDunsworth committed Feb 14, 2018
    Copy the full SHA
    a824285 View commit details

Commits on Feb 22, 2018

  1. Merge pull request #266 from EricDunsworth/v4.0-theme-svg-img

    Theme: Reference SVG logos with img element instead of object.
    
    Approve at the technical review meeting
    duboisp authored Feb 22, 2018
    Copy the full SHA
    561492b View commit details
Loading