Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Share menu css does not have latest changes from wet-boew which gives incorrect icons to most share links #2456

Open
radmorecameron opened this issue Dec 18, 2024 · 0 comments
Open

Bug - Share menu css does not have latest changes from wet-boew which gives incorrect icons to most share links #2456

radmorecameron opened this issue Dec 18, 2024 · 0 comments

Comments

@radmorecameron
Copy link

Describe the bug

Note: If your request is related to security, please do not open a publicly visible "issue"; refer to SECURITY.md.

To Reproduce

Steps to reproduce the behaviour:

  1. With the latest versions of wet-boew (4.0.83) and GCWeb (v16.0.0), create a sample page that uses the share-widget
  2. Open the share widget
  3. Notice an icon is missing next to bluesky and most of the other icons are incorrect

Example

Put this file in the root directory as GCWeb and wet-boew cdn files:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <title>Share Widget incorrect</title>
    <link rel="stylesheet" href="./GCWeb/css/theme.css" />
    <link href="https://cdn.jsdelivr.net/gh/wet-boew/[email protected]/assets/favicon-mobile.png" rel="apple-touch-icon" sizes="57x57 72x72 114x114 144x144 150x150" />
    <link href="https://cdn.jsdelivr.net/gh/wet-boew/[email protected]/assets/favicon.ico" rel="icon" type="image/x-icon" />
    <script src="./wet-boew/js/jquery/2.2.4/jquery.js"></script>
</head>
<body>

    <main>
        <h1>Share Widget Incorrect</h1>
        <div class="wb-share" data-wb-share='{"pnlId": "pnl6", "lnkClass": "btn btn-default"}'></div>
    </main>

    <script src="./wet-boew/js/wet-boew.js"></script>
    <script src="./GCWeb/js/theme.js"></script>
</body>
</html>

Current behaviour

The icons are messed up because the css wasn't updated to include Bluesky (I believe this is supposed to happen automatically?):
screenshot of share widget where an icon is missing and most icons are incorrect

Expected behaviour

This is how it looks on the wet-boew demo page (https://wet-boew.github.io/wet-boew/demos/share/share-en.html):
scrreenshot of wet-boew share widget where all icons are correct and no missing icons

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Edge
  • Version: 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@radmorecameron