Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Lua Highlighting #129

Closed
Stanzilla opened this issue Jun 28, 2020 · 3 comments
Closed

Better Lua Highlighting #129

Stanzilla opened this issue Jun 28, 2020 · 3 comments
Labels
upstream An issue related to a problem on a dependency of this plugin

Comments

@Stanzilla
Copy link

Stanzilla commented Jun 28, 2020

This is probably a highlight.js issue but if you have any pointers on how to properly request it over there, it would help as well. Currently Lua does not very highlighting at all, as an example:

image

could at least look like this

image

but considering highlightjs/highlight.js#1678 is there an alternative maybe?

@allejo
Copy link
Collaborator

allejo commented Jul 1, 2020

The Lua syntax definition is there and can be improved upon. highlight.js does currently have a maintainer but there are simply too many languages for the core team to be able to manage, which is why most language improvements come from the community.

There's an issue template for "Incorrect syntax highlighting" that you can pick to show an example of the lack of highlights. You'll likely just be invited to contribute them yourself via PRs or find someone who'd be interested in maintaining it 😅

@allejo allejo added the upstream An issue related to a problem on a dependency of this plugin label Jul 1, 2020
@Stanzilla
Copy link
Author

Exactly what I was fearing haha, should I close the issue then?

@allejo
Copy link
Collaborator

allejo commented Jul 1, 2020

Definitely create the issue over at highlight.js repo so it gets exposure and awareness. But yea, unfortunately not much we can do in this repo can do about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream An issue related to a problem on a dependency of this plugin
Projects
None yet
Development

No branches or pull requests

2 participants