Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move (most of) SierraQueryOps from Scala-libs to transformer_sierra #2562

Open
paul-butcher opened this issue Feb 21, 2024 · 0 comments
Open

Comments

@paul-butcher
Copy link
Contributor

Most of SierraQueryOps is only used in transformer_sierra, so it shouldn't be in a separately compiled library.

ItemDataOps.displayNote is used in both the API and the transformer, so a decision will need to be made as to whether to preserve the DRYness or simply copy it into both places. Given that there is already quite a lot of similarity between the two versions of SierraItemAccess, I think a bit of copy-paste is perfectly acceptable.

See Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant