Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs of file names containing # are not escaped correctly #5

Open
despens opened this issue Feb 6, 2018 · 2 comments
Open

URLs of file names containing # are not escaped correctly #5

despens opened this issue Feb 6, 2018 · 2 comments
Assignees
@despens

Comments

@despens
Copy link
Contributor

despens commented Feb 6, 2018 •
edited
Loading

Possibly hinting at other escaping issues.

Example:

WARC/1.0
WARC-Date: 2004-11-10T16:15:13Z
WARC-Source-URI: file://waste/images/17#.jpg
WARC-Created-Date: 2018-02-06T16:26:13Z
WARC-Type: resource
WARC-Record-ID: <urn:uuid:73015799-0b5a-11e8-9ac5-5ce0c57ec2e1>
WARC-Target-URI: http://heise.de/tp/kunst/waste/images/17#.jpg
WARC-Payload-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
WARC-Block-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
Content-Type: image/jpeg
Content-Length: 5222

Should be:

WARC/1.0
WARC-Date: 2004-11-10T16:15:13Z
WARC-Source-URI: file://waste/images/17#.jpg
WARC-Created-Date: 2018-02-06T16:26:13Z
WARC-Type: resource
WARC-Record-ID: <urn:uuid:73015799-0b5a-11e8-9ac5-5ce0c57ec2e1>
WARC-Target-URI: http://heise.de/tp/kunst/waste/images/17%23.jpg
WARC-Payload-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
WARC-Block-Digest: sha1:GLC3CKKQ4LSVN4FD75TBXBOOAHA6WP6N
Content-Type: image/jpeg
Content-Length: 5222
@despens despens self-assigned this Feb 6, 2018
@despens despens mentioned this issue Feb 7, 2018
Closed
@despens
Copy link
Contributor Author

despens commented Feb 12, 2018

Fixed by #2

@despens
Copy link
Contributor Author

despens commented Jun 7, 2018

Fixed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@despens despens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@despens