Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO3 12 #20

Open
fritzdacat opened this issue Mar 31, 2023 · 14 comments
Open

TYPO3 12 #20

fritzdacat opened this issue Mar 31, 2023 · 14 comments
Assignees

Comments

@fritzdacat
Copy link

What are the plans for TYPO3 12?
Is there already a schedule when deferred_image_processing for TYPO3 12 will be available?

@thommyhh thommyhh self-assigned this Apr 3, 2023
@thommyhh
Copy link
Contributor

thommyhh commented Apr 3, 2023

@fritzdacat I guess with the feature freeze of 12.3 it would be a good time now. Unfortunately I don't have a v12 project yet. I start the next project (with v12) in a few weeks. I should be able to use it there.

@xerc
Copy link
Contributor

xerc commented Oct 2, 2023

@hacksch
Copy link

hacksch commented Jul 23, 2024

@xerc
Please check in your fork in Classes/Resource/Processing/DeferredImageProcessor.php in line 91-92. the variable should be names "$imageDimension" instead "$imageDimensions"

@xerc
Copy link
Contributor

xerc commented Jul 23, 2024

fix & maybee also this .. ?!

diff --git a/Classes/Resource/Processing/DeferredImageProcessor.php
@@ -27,6 +27,8 @@ class DeferredImageProcessor extends LocalImageProcessor
             && $task->getSourceFile()->getProperty('height') > 0
             && $task->getSourceFile()->getMimeType() !== 'image/svg+xml'
             && $task->getSourceFile()->getMimeType() !== 'application/pdf'
+            && !($GLOBALS['TSFE']->config['config']['tx_headless.']['staticTemplate'] ?? false)
+            && !($GLOBALS['TYPO3_REQUEST']->getAttribute('site')->getConfiguration()['headless'] ?? false)
         ;
     }

@hacksch
Copy link

hacksch commented Jul 30, 2024

Thanks for fix the variable name.
Can't say what impact these lines will have because i don't have a headless instance. Maybe this should be configurable.

Additonially i found another problem in the DeferredImageProcessor.php, line 75-84.
There is a check if the dimensions of the original and target file are the same and the original file will taken. I run into a problem here when i change the file extension (e.g. jpeg to webp). The dimension are the same but the file extension is different and i get the original image. A check for changed file extension is required.

@hacksch
Copy link

hacksch commented Jul 30, 2024

And the verbose argument in the cli command needs to be removed. In TYPO3 v12 vendor/bin/typo3cms doesn't exists anymore and the cli can be executed by using vendor/bin/typo3 and it looks like a verbose arguments exists by default

@xerc
Copy link
Contributor

xerc commented Aug 3, 2024

not tested ; xerc@af185c0

@xerc
Copy link
Contributor

xerc commented Aug 3, 2024

you may shall check out helhum/typo3-console

@hacksch
Copy link

hacksch commented Aug 14, 2024

@xerc
I have the typo3-console installed but with v8 it changed. see doc https://github.com/TYPO3-Console/TYPO3-Console

@xerc
Copy link
Contributor

xerc commented Aug 15, 2024

would be easier if you could specify - how to change - and give detailed links on how to use this argument within - thx

@hacksch
Copy link

hacksch commented Aug 27, 2024

I only removed the registration of the verbos argument in Classes/Command/ProcessCommand.php to make it work again.

@xerc
Copy link
Contributor

xerc commented Aug 27, 2024

I only removed the registration of the verbos argument in Classes/Command/ProcessCommand.php

you may please create a push-req. @ my branch

how can we use the /typo3 --verbose mode?

@xerc
Copy link
Contributor

xerc commented Nov 26, 2024

@thommyhh do you (and/or your team) have time to upgrade/maintain this EXT these days? t3 v13 is already stable :)

@thommyhh
Copy link
Contributor

@xerc I'll see what I can do. I guest, I have to test it with my own website, as I don't have other v13 projects yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants