Improve APT package check in the Assistant

[davidcr01]

Context

Working on #2879, I noticed that the installation in the RPM system was significantly faster than the installation in the APT system. This behavior could be normal as they are different OSs.

However, I noticed that the Installation assistant in the APT systems is slowed by the APT package manager, specifically while checking the installed packages.

Currently:

• In APT systems, we use apt list --installed | grep <package_name> to check if a package is installed.
• In RPM systems, we used yum list installed | grep <package_name> to check if a package is installed until 4.8.2. In this PR, the command was changed to rpm -q <package_name> because the original command was causing trouble with the YUM lock. Besides, the new command was faster than the original command.

Description

The aim of this issue is to try to improve the performance of the APT packages check. I've done some research about the consumed time of these commands:

• We can see that to check if a package is installed using the apt list option, the CPU consumes about 0.5 seconds (considering user+sys times).

root@ip-172-31-71-48:/home/ubuntu# time apt list --installed | grep -E ^"curl"

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

curl/jammy-updates,jammy-security,now 7.81.0-1ubuntu1.16 amd64 [installed]

real    0m0.506s
user    0m0.497s
sys     0m0.011s

• Using another option, for example dpkg filtering with the ii string (check if it's actually installed), the time consumed is significantly lower, taking 0.32 seconds:

root@ip-172-31-71-48:/home/ubuntu# time dpkg -l curl | grep -E '^ii\s'
ii  curl           7.81.0-1ubuntu1.16 amd64        command line tool for transferring data with URL syntax

real    0m0.030s
user    0m0.014s
sys     0m0.018s

To reaffirm this hypothesis, I created a simple script to chronometer the time consumed checking a package list. I used the following script:

#!/bin/bash

# List of packages to check
packages=(systemd grep tar coreutils sed gawk curl lsof openssl)

dpkg_total_time=0
apt_total_time=0

# Measure total time for dpkg
dpkg_start_time=$(date +%s%3N)
for package in "${packages[@]}"; do
    dpkg -l $package | grep -E '^ii\s' > /dev/null
done
dpkg_end_time=$(date +%s%3N)
dpkg_total_time=$((dpkg_end_time - dpkg_start_time))

# Measure total time for apt
apt_start_time=$(date +%s%3N)
for package in "${packages[@]}"; do
    apt list --installed 2>/dev/null | grep -q -E ^"${package}" > /dev/null
done
apt_end_time=$(date +%s%3N)
apt_total_time=$((apt_end_time - apt_start_time))

# Output the results
echo "Total time for dpkg: $dpkg_total_time ms"
echo "Total time for apt: $apt_total_time ms"

The results were the following:

root@ip-172-31-71-48:/home/ubuntu# bash measure.sh 
Total time for dpkg: 135 ms
Total time for apt: 5240 ms

Note

With the new option, the package list check is 38.81 times faster, in other words, 97,42% faster.

Changes

The involved changes are the following:

See all changes

• wazuh-packages/unattended_installer/common_functions/common.sh

  Line 94 in 6f5758e

  wazuh_installed=$(apt list --installed 2>/dev/null | grep wazuh-manager)

• wazuh-packages/unattended_installer/common_functions/common.sh

  Line 106 in 6f5758e

  indexer_installed=$(apt list --installed 2>/dev/null | grep wazuh-indexer)

• wazuh-packages/unattended_installer/common_functions/common.sh

  Line 117 in 6f5758e

  filebeat_installed=$(apt list --installed 2>/dev/null | grep filebeat)

• wazuh-packages/unattended_installer/common_functions/common.sh

  Line 128 in 6f5758e

  dashboard_installed=$(apt list --installed 2>/dev/null | grep wazuh-dashboard)

• wazuh-packages/unattended_installer/install_functions/checks.sh

  Lines 473 to 478 in 6f5758e

  	if apt list --installed 2>/dev/null | grep -q -E ^"firewalld"\/; then
  	firewalld_installed=1
  	fi
  	if apt list --installed 2>/dev/null | grep -q -E ^"ufw"\/; then
  	ufw_installed=1
  	fi

• wazuh-packages/unattended_installer/install_functions/installCommon.sh

  Line 124 in 6f5758e

  if ! apt list --installed 2>/dev/null | grep -q -E ^"${dep}"\/; then

• wazuh-packages/unattended_installer/install_functions/installCommon.sh

  Line 604 in 6f5758e

  eval "apt list --installed 2>/dev/null | grep wazuh-manager"

• wazuh-packages/unattended_installer/install_functions/installCommon.sh

  Line 632 in 6f5758e

  eval "apt list --installed 2>/dev/null | grep wazuh-indexer"

• wazuh-packages/unattended_installer/install_functions/installCommon.sh

  Line 661 in 6f5758e

  eval "apt list --installed 2>/dev/null | grep filebeat"

• wazuh-packages/unattended_installer/install_functions/installCommon.sh

  Line 690 in 6f5758e

  eval "apt list --installed 2>/dev/null | grep wazuh-dashboard"

• wazuh-packages/unattended_installer/install_functions/wazuh-offline-installation.sh

  Line 21 in 6f5758e

  eval "apt list --installed 2>/dev/null | grep -q -E ^"${dep}"\/"

Tasks

• Validate if the dpkg proposed option fits the requirements.
• If so, change the apt occurrences with the dpkg.
• Check if the packages are correctly checked.
• Perform several installations to enhance the testing.