Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not listen/handle programmatic route changes #490

Open
robstoll opened this issue Dec 17, 2021 · 1 comment
Open

do not listen/handle programmatic route changes #490

robstoll opened this issue Dec 17, 2021 · 1 comment
Assignees
@robstoll
Labels
cleanup

Comments

@robstoll
Copy link
Contributor

The current implementation listens on routeParam and queryParam changes and acts accordingly, i.e. jump to the corresponding location on the map. This behaviour is desired for the first time when a user has entered a corresponding url in to the address bar.
Yet, once the user is on the page and e.g. flies to another city, where we change the route programmatically due to the city change, it is unnecessary to process the routeParam change in addition (and fly one more time to the corresponding location).
@robstoll robstoll changed the title do not handle programmatic route changes do not listen/handle programmatic route changes Dec 17, 2021
@robstoll robstoll added this to Board Dec 17, 2021
@robstoll robstoll moved this to In Progress in Board Dec 17, 2021
@robstoll robstoll self-assigned this Dec 17, 2021
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
18f2762 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
@robstoll robstoll mentioned this issue Dec 17, 2021
Merged
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
039d94c 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
1724149 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#491 loc / water-fountains#493 map.resize / water-foun…
64fe564 
…tains#489 switch between cities

moreover:
- water-fountains#490 do not handle programmatic route changes
- fix some null vs. undefined issues
- update mapboxgl to latest version

not included yet in this commit:
- loading fountains outside of a city
@robstoll robstoll moved this from In Progress to Verify in Board Dec 17, 2021
@robstoll robstoll moved this from Verify to In Progress in Board Dec 17, 2021
@robstoll
Copy link
Contributor Author

Note that we still need to listen for browser back button changes

@robstoll robstoll moved this from In Progress to Verify in Board Dec 17, 2021
@robstoll robstoll moved this from Verify to In Progress in Board Dec 17, 2021
robstoll added a commit to tegonal/proximap that referenced this issue Dec 17, 2021
@robstoll
water-fountains#490 check for programmatic routing
0faf238 
I figured it would be enough to have a guard in MapService to not
emit a new state in case it is the same as the current. Yet, I was
proven to be wrong and it definitely better to not process a
programmatic route change twice.
@robstoll robstoll moved this from In Progress to Verify in Board Dec 17, 2021
robstoll added a commit that referenced this issue Dec 17, 2021
@robstoll
Merge pull request #501 from tegonal/#490-programmatic-routing
8a2b759 
#490 check for programmatic routing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robstoll robstoll

Labels
cleanup
Projects
Board
Status: Verify
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robstoll