fix: re-enable @waku/tests for CI #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
weboko
reviewed
Aug 11, 2023
danisharora099
force-pushed
the
chore/reset-test
branch
from
49907ac
to
7ece78c
Compare
danisharora099
force-pushed
the
chore/reset-test
branch
from
def98d5
to
f3c20d3
Compare
|
Failing peer-exchange compliance test might be related to libp2p/js-libp2p#1846 investigation led to a conclusion that |
fryorcraken
approved these changes
Aug 14, 2023
|
Merging this PR with failing test tracked here: #1477 |
danisharora099
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: update noise * update: package.lock * update: @chainsafe/libp2p-gossipsub * rm unwanted libp2p interface deps & bump up libp2p * refactor code for new deps * update: new package.lock * update package.lock * fix build * chore(deps)(deps-dev): bump eslint-plugin-functional from 5.0.8 to 6.0.0 (#1479) Bumps [eslint-plugin-functional](https://github.com/eslint-functional/eslint-plugin-functional) from 5.0.8 to 6.0.0. - [Release notes](https://github.com/eslint-functional/eslint-plugin-functional/releases) - [Changelog](https://github.com/eslint-functional/eslint-plugin-functional/blob/main/CHANGELOG.md) - [Commits](eslint-functional/eslint-plugin-functional@v5.0.8...v6.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-functional dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(peer-exchange): refactor/fix compliance test (#1478) * use `peer:identify` instead of `peer:update` * dial the peer after initialising peer-exchange * re-enable @waku/tests (#1472) * chore(deps)(deps): bump @libp2p/websockets from 6.0.3 to 7.0.3 (#1481) Bumps [@libp2p/websockets](https://github.com/libp2p/js-libp2p) from 6.0.3 to 7.0.3. - [Release notes](https://github.com/libp2p/js-libp2p/releases) - [Changelog](https://github.com/libp2p/js-libp2p/blob/master/.release-please.json) - [Commits](libp2p/js-libp2p@peer-record-v6.0.3...websockets-v7.0.3) --- updated-dependencies: - dependency-name: "@libp2p/websockets" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * import type for interface * update: tsdoc (#1476) * fix imports for merge * update typedoc exports * add: CustomEvent import * use new libp2p interface --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
danisharora099
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: update noise * update: package.lock * update: @chainsafe/libp2p-gossipsub * rm unwanted libp2p interface deps & bump up libp2p * refactor code for new deps * update: new package.lock * update package.lock * fix build * chore(deps)(deps-dev): bump eslint-plugin-functional from 5.0.8 to 6.0.0 (#1479) Bumps [eslint-plugin-functional](https://github.com/eslint-functional/eslint-plugin-functional) from 5.0.8 to 6.0.0. - [Release notes](https://github.com/eslint-functional/eslint-plugin-functional/releases) - [Changelog](https://github.com/eslint-functional/eslint-plugin-functional/blob/main/CHANGELOG.md) - [Commits](eslint-functional/eslint-plugin-functional@v5.0.8...v6.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-functional dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(peer-exchange): refactor/fix compliance test (#1478) * use `peer:identify` instead of `peer:update` * dial the peer after initialising peer-exchange * re-enable @waku/tests (#1472) * chore(deps)(deps): bump @libp2p/websockets from 6.0.3 to 7.0.3 (#1481) Bumps [@libp2p/websockets](https://github.com/libp2p/js-libp2p) from 6.0.3 to 7.0.3. - [Release notes](https://github.com/libp2p/js-libp2p/releases) - [Changelog](https://github.com/libp2p/js-libp2p/blob/master/.release-please.json) - [Commits](libp2p/js-libp2p@peer-record-v6.0.3...websockets-v7.0.3) --- updated-dependencies: - dependency-name: "@libp2p/websockets" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * import type for interface * update: tsdoc (#1476) * fix imports for merge * update typedoc exports * add: CustomEvent import * use new libp2p interface --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/waku-org/js-waku/pull/1432/files#diff-144f300b82cf47742d189b111e0e0c2d903acd00c67564944d4bb8442c00c254 changed the script name from
test:nodetotestwhich now never runs our test suite within@waku/testsSolution
Re-enable tests