Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connection manager should mark un-dialable peers #2188

Open
weboko opened this issue Oct 16, 2024 · 0 comments
Open

feat: connection manager should mark un-dialable peers #2188

weboko opened this issue Oct 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Oct 16, 2024

Statement

Received from feedback: https://github.com/waku-org/support/issues/2

"Would be great if nodes can forget about peers they can't connect to."

Solution

Implement some marking for such peers and prevent them from being dialed for some time.
We shouldn't block them forever as dialing can fail due to capacity of websocket connections nwaku can support (~300 now).
Handle edge case when there are only un-dialable nodes present.

Additionally add telemetry to https://lab.waku.org/dogfooding to measure dial failures and root causes.
Do additional dogfooding after that.

@weboko weboko added the enhancement New feature or request label Oct 16, 2024
@weboko weboko added this to Waku Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

1 participant