[Epic] Peer Exchange is supported and used by default

[fryorcraken]

Planned start date:
Due date:

Summary

This milestone tracks the development, testing and hardening of 34/WAKU2-PEER-EXCHANGE protocol in js-waku.

Acceptance Criteria

• Waku Peer Exchange enables js-waku client to find peers, outside the waku v2 fleet.
• Waku Peer Exchange is part of the defaultBootstrap protocol for js-waku, it connects to peer exchange peers BUT only use bootstrap peer for filter, store: feat!: set peer-exchange with default bootstrap #1469. peer exchange + bootstrap peers are used for light push.

Tasks

• Dogfood peer-exchange curation in web-chat example #1309
• [Connection Manager] Improve fallback mechanism when remote peer rejects connection #1326
• chore: investigate peer:identify timeouts  #1431 -> chore: refactor peer-exchange compliance test #1468
• peer-exchange browser feedback #1454
• feat!: set peer-exchange with default bootstrap #1469
• chore(peer-exchange): refactor/fix compliance test #1478
• peer-exchange: dappnode advertises ws instead of wss #1526
• web-chat: inconsistency with peers connected on the left and the right of the UI examples.waku.org#264

Notes

Finding other Waku Store services using peer exchange is out of scope due to the current federated nature/high requirements on Waku Store service node.
Tracking the usage of peer exchange to find other store node is part of decentralisation of Waku Store roadmap.

RAID (Risks, Assumptions, Issues and Dependencies)

• Dogfooding must happen.
• depends on nwaku/research to improve the protocol.

[danisharora099]

Weekly Update

• achieved: robustness around peer-exchange, and highlight discovery vs connections for PX on the web-chat example
• next: saving successfully connected PX peers to local storage for easier connections on reload

[fryorcraken]

Thinking how we can deliver this with a net positive in terms of reliability.
The main risk is connecting to node that are unreliable.

I would recommend to make peer exchange by default:

• Keep using bootstrap node for store (1) + light push (1) + filter (1)
• implement redundant usage of light push and filter on peer discovery nodes (ie, filter subscrive to 2-3 nodes, including one bootstrap).

That would be enough to use peer exchange and close the issue.
Further work such as remembering discovered peers and having some sort of scoring can be done with follow-up milestones.

[fryorcraken]

@danisharora099 see my comment above #1429 (comment)

I don't think #1326 should be part of the scope of this issue.
Let's limit the scope of peer exchange so we can ship it.

[danisharora099]

@fryorcraken thanks!

could you explain this what we mean by this?

implement redundant usage of light push and filter on peer discovery nodes (ie, filter subscrive to 2-3 nodes, including one bootstrap).

not sure what i'm missing: if we setup redundant usage, we would start receiving multiple messages on subscription, and also pushing the same message multiple times

[fryorcraken]

not sure what i'm missing: if we setup redundant usage, we would start receiving multiple messages on subscription, and also pushing the same message multiple times

Yes absolutely. Which is why we will need to have a duplicate filtering mechanism in place on js-waku side to not emit dupe messages to the API, as described in the Notes of #1463

Sending the same message twice over light push using 2 different nodes is fine and enables you to put less trust on one remote peer.
The message will not be "duplicated" over the relay network as it's actually very similar on how the relay network works: seending the same messages to all peers in the mesh.

[danisharora099]

Weekly update

• achieved: close the "fallback mechanism for peer rejections", refactor peer-exchange compliance test
• next: peer-exchange to be included with default discovery, action peer-exchange browser feedback

[danisharora099]

Weekly update

• achieved: peer-exchange included by default (PR opened)
• next: tasks breakdown and followup from dogfooding feedback

[danisharora099]

Weekly Update

• achieved: break down dogfooding into tasks for peer-exchange

[danisharora099]

Weekly Update

• achieved: Peer Exchange is now merged included in defaultBootstrap
• next: followup on browser investigation and confirm if the EPIC can be safely closed

[danisharora099]

tracking some work on circuit relay here: #1527

[danisharora099]

Weekly Update

• achieved: The Peer Exchange Epic is now completed & closed