How to fix video fullscreening to window instead of whole display

[tywil04]

As the title suggests, I am having issues with a video element. I am using the svelte template and this is the code for the video element:

<video controls>
    <source src="https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.webm" type="video/webm"/>
    <source src="https://interactive-examples.mdn.mozilla.net/media/cc0-videos/flower.mp4" type="video/mp4"/>
    <track kind="captions"/>
</video>

When I go to fullscreen the video element, instead of the expected behavior (fullscreening to the whole display) the element fullscreens to the wails window. Am I doing something wrong or is this a potential bug?

[leaanthony]

It's not a Wails big per se as you aren't using any Wails features here. It might be an issue with the webview though. What OS? Did you try the other OSes?

[leaanthony]

Wow, that's significantly better than before!

[leaanthony]

@tywil04 - Would it be possible to get a video of the "before" - without the JS fix? I'm going to open a new ticket and it would be good to show the difference that small delay makes.

[tywil04]

Sure thing!

I have re-recorded the video with the delay fix so its using a minimal starting point instead of a test view in my project.

With delay fix:
https://github.com/wailsapp/wails/assets/68185249/c483381b-9636-41ff-af93-2db1faaeefe8

Without delay fix:
https://github.com/wailsapp/wails/assets/68185249/4b549601-333e-4d44-9563-a1ad350349a7

Without the small delay (1ms) the effect works when fullscreening but when exiting fullscreen the window won't unmaximise, its a really small quirk that I could only solve by introducing the small delay. I did also install the delay when fullscreening even though its not strictly necessary because the effect it produces looks more pleasing to me because it more closely matches the effect when exiting fullscreen.

[leaanthony]

Thanks so much for this 🙏I'd be so curious to know if this is an issue on Mac. I'll open the issue soon

[tywil04]

Unfortunately I don't have access to a Mac.