Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Judge API Param 목록 Model로 관리 #5

Open
minkyu97 opened this issue Jul 11, 2023 · 1 comment
Open

Judge API Param 목록 Model로 관리 #5

minkyu97 opened this issue Jul 11, 2023 · 1 comment

Comments

@minkyu97
Copy link
Collaborator

minkyu97 commented Jul 11, 2023

judge api 문서에 param 목록이 있는걸로 아는데
list[str]말고 pydantic model로 type safe하게 관리하는건 어떨까요
이런식으루

class JudgeQueryParams(BaseModel):
    base64_encoded: bool = False
    ...  # 그 외 나올 수 있는 params

Originally posted by @shp7724 in #4 (comment)

@minkyu97
Copy link
Collaborator Author

@shp7724 제안해준 거 이슈로 만들어놨고, 앞으로도 리팩토링할 거 보이면 여기에 이슈로 파놓읍시다
cc. @fivessun5 @serverrepairman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant