Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails for newer versions of martinez-polygon-clipping #47

Open
ianstormtaylor opened this issue Dec 3, 2022 · 0 comments
Open

Fails for newer versions of martinez-polygon-clipping #47

ianstormtaylor opened this issue Dec 3, 2022 · 0 comments

Comments

@ianstormtaylor
Copy link

This isn't technically a current problem, but it will be whenever the package updates its internal martinez-polygon-clipping dependency.

I had a setup where I was accidentally leaving the martinez-polygon-clipping dependency unpegged and it was importing the newest ~0.7 version and returning weird outputs with non-conforming polygon arrays when union was called internally. I'd end up with a return value of:

[
  [number, number][],
  [number, number],
  [number, number],
  [number, number],
  [number, number],
  ...
]

Instead of:

[number, number][][]

And it took me forever to track down that the internal dependency was unpegged.

Anyways, not a current issue, but it seems like the jump from [email protected] to [email protected] might break things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant