-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make grid pattern appear #112
Conversation
✅ Deploy Preview for wai-aria-practices2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@alflennik I see Grid present and the content looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alflennik looks good to me other than the comment relating to the alphabetical order on the patterns page. Good stuff!
Another thing of note is on Data Grid Examples Page, Example 2: Sortable Data Grid With Editable Cells. There appears to be some conflicting CSS here which is forcing the edit icon over the column line for its respective cell. But that's outside the purpose of this PR and I believe there may be an over-arching task to account for these kind of tasks? If not, it could be filed in a separate issue.
@howard-e I decided to go ahead and fix the offending example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alflennik looks good and thanks for taking the time to address the non-blocking CSS issue as well!
Thank you @alflennik!!! |
Address issue #102.