-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to graph isomorphism #128
Comments
I will take care of this one. |
I was just about to implement the change as proposed in the issue description above. Yet, it turns out that it may not be exactly that simple, for the following reasons: By the current definition, the domain of the bijection_M_ is the set of all nodes of the graph G. Yet, it is not guaranteed that any of the three elements of the triple term tt = (s, p, o) is such a node. Therefore, M(s) may be undefined, and so may M(p) and M(o). The fix to this problem may be to change the domain and the co-domain of the bijection M to both be the set of all RDF terms. With this change, the extra clause mention in the issue description above can then be added without problems. So, to be explicit, in addition to adding this extra clause we need to change the sentence before the bullet points in the section. I propose to change that sentence as follows:
I will implement this change once PR #137 is merged. |
Good catch |
Also, note that M(p) is not necessary in the recursion (p is always an IRI, so M(p) is always equal to p). |
As far as I can tell, graph isomorphism needs the following extra clause
This is slightly clunky but doesn't use any concrete syntax.
The text was updated successfully, but these errors were encountered: